Skip to content

ci: repoint reusable workflows to devantler-tech/actions v8.0.0#80

Merged
devantler merged 2 commits into
mainfrom
claude/ci-repoint-actions
Jul 3, 2026
Merged

ci: repoint reusable workflows to devantler-tech/actions v8.0.0#80
devantler merged 2 commits into
mainfrom
claude/ci-repoint-actions

Conversation

@devantler

@devantler devantler commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🤖 Generated by the Daily AI Assistant

Why

Our reusable CI workflows moved to devantler-tech/actions; this repo still builds and signs its releases from the old repo, which can't be archived until everyone moves — and which now fails nightly (reusable-workflows#350).

What

Points this repo's CI and release workflows at the new home. Same workflows, no behavior change.

Part of devantler-tech/actions#425.

⚠️ Merge order: land devantler-tech/platform#2399 first — the platform must trust the new signing home, or this repo's next release is rejected and its deployment stops updating.
👉 After promotion: needs a direct merge (auto-merge can't touch workflow files).

Part of devantler-tech/actions#425 (consumer migration off the legacy
reusable-workflows repo).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two GitHub Actions workflows now call reusable workflows from devantler-tech/actions v8.0.0 instead of devantler-tech/reusable-workflows. The CD workflow also updates related inline comments and reference paths.

Changes

Reusable workflow reference migration

Layer / File(s) Summary
Update CD workflow references
.github/workflows/cd.yaml
Inline documentation is updated, and the publish-manifests job now uses devantler-tech/actions v8.0.0.
Update release workflow reference
.github/workflows/release.yaml
The release job now invokes the release-creation reusable workflow from devantler-tech/actions pinned to a v8.0.0 commit SHA.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the workflow reference migration to devantler-tech/actions v8.0.0.
Description check ✅ Passed The description is directly related to the workflow migration and notes the same no-behavior-change intent.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/ci-repoint-actions

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/cd.yaml (1)

3-17: 🗄️ Data Integrity & Integration | 🔵 Trivial | 💤 Low value

Update the OIDC path note. The signing workflow now comes from devantler-tech/actions/.github/workflows/publish-manifests.yaml@<ref>, so this comment should stop referencing devantler-tech/reusable-workflows.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/cd.yaml around lines 3 - 17, Update the OIDC subject/path
note in this comment to match the actual reusable signing workflow source,
changing the reference from devantler-tech/reusable-workflows to
devantler-tech/actions/.github/workflows/publish-manifests.yaml@<ref>. Keep the
rest of the explanation intact, and make sure the guidance still points readers
to the cosign certificate identity used by the publish-manifests flow in
cd.yaml.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/cd.yaml:
- Around line 3-17: Update the OIDC subject/path note in this comment to match
the actual reusable signing workflow source, changing the reference from
devantler-tech/reusable-workflows to
devantler-tech/actions/.github/workflows/publish-manifests.yaml@<ref>. Keep the
rest of the explanation intact, and make sure the guidance still points readers
to the cosign certificate identity used by the publish-manifests flow in
cd.yaml.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ff0a96b-8c1c-4576-8d29-3074481b1243

📥 Commits

Reviewing files that changed from the base of the PR and between c8d803e and 6ebb71c.

📒 Files selected for processing (2)
  • .github/workflows/cd.yaml
  • .github/workflows/release.yaml

…flow

CodeRabbit nitpick on this PR; also fixes the stale platform file pointer
and records the platform-verifier-first merge ordering.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Daily AI Assistant

CodeRabbit review-body nitpick resolved (no thread exists to resolve, so this comment is the resolution record): the header comment's OIDC note now points at devantler-tech/actions/.github/workflows/publish-manifests.yaml@<ref> and at the verifier's real location (k8s/bases/apps/github-config/oci-repository.yaml — the old k8s/providers/hetzner/github/sync.yaml pointer was stale). Pushed in 27d4cbc.

The nitpick also surfaced a real sequencing issue: the platform verifier's subject is pinned to the reusable-workflows path, so this PR must land after devantler-tech/platform#2399 (which accepts both subjects during the transition) — otherwise the next v* tag's artifact fails cosign verification and the github-config tenant stops syncing. My original body claim that the verifier "matches @.+$" only covered the ref, not the repo path — corrected.

@devantler devantler marked this pull request as ready for review July 3, 2026 02:20
@devantler devantler merged commit 533425e into main Jul 3, 2026
9 checks passed
botantler-1 Bot pushed a commit to devantler-tech/monorepo that referenced this pull request Jul 3, 2026
…. nitpicks (#2041)

* docs(agents): sweep ALL CodeRabbit review-body finding sections, incl. nitpicks

Maintainer direction 2026-07-03 (live case devantler-tech/.github#80):
'🧹 Nitpick comments' sections in review bodies never become threads and
were invisible to the Outside-diff-range-only grep. Generalize the
review-body rule to every collapsed finding section, extend the survey
jq filter, and make the surveyor definition carry the full hygiene-triad
check itself (it previously relied on the caller's prompt).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(agents): match CodeRabbit body-finding sections by shape, not title list

Every CodeRabbit finding section is titled '<emoji> <Category> comments (N)';
matching that shape (excluding only the informational 🔇 Additional comments)
keeps future category titles from silently escaping the body_findings count.
Verified live: ksail#5738 counts 2, monorepo#2041 counts 0.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(agents): count body-finding sections per review with scan-and-sum, not select-per-review

A single CodeRabbit review can carry both an Outside-diff-range and a
Nitpick section; select(test(...)) counted it once and under-reported
body_findings.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant